build(docker): add web, control-center in docker-compose #4190
Conversation
There was a problem hiding this comment.
Thanks for the PR, @Dhanus3133!
Also, how is the user expected to configure the publishable and API keys, and the remaining URLs?
SanchithHegde
added
A-infra
Resolved it. |
|
I noticed that one of the PRs closely mirrors mine. Just wanted to bring this matter to your attention. |
| env_file: | ||
| - ./.env |
There was a problem hiding this comment.
Could you provide an example of what this .env file would contain? Including placeholder values should be good enough.
|
@SanchithHegde do you know why this happens? |
If you're running the web client and demo app within a Docker container, and use |
| - apiBaseUrl=http://hyperswitch-server:8080 | ||
| - sdkBaseUrl=http://hyperswitch-web:9050 |
There was a problem hiding this comment.
this won't work since the communication is initiated via browser here and not via the docker container
| EXPOSE 5252 | ||
| EXPOSE 9060 | ||
|
|
||
| CMD concurrently "npm run start:dev" "npm run start:playground" |
There was a problem hiding this comment.
this npm command has been removed sometime ago here.
| RUN sed -i '/hot: true,/a \ host: "0.0.0.0",' webpack.dev.js | ||
| RUN sed -i '/hot: true,/a \ host: "0.0.0.0",' Hyperswitch-React-Demo-App/webpack.dev.js |
There was a problem hiding this comment.
might not be needed since after this.
| hyperswitch-server: | ||
| condition: service_started |
There was a problem hiding this comment.
@Dhanus3133 can you remove this since we want the option to run this along with local server.
i.e using the local cargo run along with docker services for hyperswitch-web & hyperswitch-control-center.
| depends_on: | ||
| hyperswitch-server: | ||
| condition: service_started |
There was a problem hiding this comment.
@Dhanus3133 can you remove this since we want the option to run this along with local server.
i.e using the local cargo run along with docker services for hyperswitch-web & hyperswitch-control-center.
| - router_net | ||
| environment: | ||
| - apiBaseUrl=http://hyperswitch-server:8080 | ||
| - sdkBaseUrl=http://hyperswitch-web:9050 |
There was a problem hiding this comment.
The sdkBaseUrl should point to the js assets, in this case it would be sdkBaseUrl=http://<SDK_SERVICE>/HyperLoader.js
SanchithHegde
removed
the
S-waiting-on-author
Added hyperswitch-web and hyperswitch-control-center in docker-compose
Type of Change
Description
Two new services were added to start the SDK, demo, and control center automatically within docker-compose.
Solves #4110
Additional Changes